Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 98a9c8c3 authored by Hidetoshi Seto's avatar Hidetoshi Seto Committed by H. Peter Anvin
Browse files

x86, mce: trivial clean up for mce-inject.c 



Fix for:

WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
+#include <asm/uaccess.h>

WARNING: usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc
+       if (m.cpu >= NR_CPUS || !cpu_online(m.cpu))

ERROR: trailing whitespace
+/* $

Signed-off-by: default avatarHidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: Andi Kleen <andi@firstfloor.org>
Signed-off-by: default avatarH. Peter Anvin <hpa@zytor.com>
parent 61a021a0

arch/x86/kernel/cpu/mcheck/mce-inject.c

+2 −2
Original line number Diff line number Diff line
@@ -11,13 +11,13 @@ 
 * Andi Kleen

 * Ying Huang

 */

#include <linux/uaccess.h>

#include <linux/module.h>

#include <linux/timer.h>

#include <linux/kernel.h>

#include <linux/string.h>

#include <linux/fs.h>

#include <linux/smp.h>

#include <asm/uaccess.h>

#include <asm/mce.h>



/* Update fake mce registers on current CPU. */
@@ -93,7 +93,7 @@ static ssize_t mce_write(struct file *filp, const char __user *ubuf, 
	if (copy_from_user(&m, ubuf, usize))

		return -EFAULT;



	if (m.cpu >= NR_CPUS || !cpu_online(m.cpu))

	if (m.cpu >= num_possible_cpus() || !cpu_online(m.cpu))

		return -EINVAL;



	dm = kmalloc(sizeof(struct delayed_mce), GFP_KERNEL);