Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 98a37510 authored by Yann Droneaud's avatar Yann Droneaud Committed by Roland Dreier
Browse files

IB/uverbs: Set error code when fail to consume all flow_spec items 

If the flow_spec items parsed count does not match the number of items
declared in the flow_attr command, or if not all bytes are used for
flow_spec items (eg. trailing garbage), a log message is reported and
the function leave through the error path. Unfortunately the error
code is currently not set.

This patch set error code to -EINVAL in such cases, so that the error
is reported to userspace instead of silently fail.

Link: http://marc.info/?i=cover.1386798254.git.ydroneaud@opteya.com

>
Signed-off-by: default avatarYann Droneaud <ydroneaud@opteya.com>
Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
parent c780d82a

drivers/infiniband/core/uverbs_cmd.c

+1 −0
Original line number Diff line number Diff line
@@ -2738,6 +2738,7 @@ int ib_uverbs_ex_create_flow(struct ib_uverbs_file *file, 
	if (cmd.flow_attr.size || (i != flow_attr->num_of_specs)) {

		pr_warn("create flow failed, flow %d: %d bytes left from uverb cmd\n",

			i, cmd.flow_attr.size);

		err = -EINVAL;

		goto err_free;

	}

	flow_id = ib_create_flow(qp, flow_attr, IB_FLOW_DOMAIN_USER);