Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 981c982c authored by Lalit Chandivade's avatar Lalit Chandivade Committed by James Bottomley
Browse files

[SCSI] qla4xxx: Fix un-necessary delay on invalid DDB 



Fix the un-necessary wait for completion of a sendtarget on an
invalid DDB entry. The state of an invalid DDB entry is 0 (unassigned)

This will also avoid the delays during system boot.

Signed-off-by: default avatarLalit Chandivade <lalit.chandivade@qlogic.com>
Signed-off-by: default avatarVikas Chaudhary <vikas.chaudhary@qlogic.com>
Reviewed-by: default avatarMike Christie <michaelc@cs.wisc.edu>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 45857216

drivers/scsi/qla4xxx/ql4_mbx.c

+2 −0
Original line number Diff line number Diff line
@@ -661,6 +661,8 @@ int qla4xxx_get_fwddb_entry(struct scsi_qla_host *ha, 
	}

	memset(&mbox_cmd, 0, sizeof(mbox_cmd));

	memset(&mbox_sts, 0, sizeof(mbox_sts));

	if (fw_ddb_entry)

		memset(fw_ddb_entry, 0, sizeof(struct dev_db_entry));



	mbox_cmd[0] = MBOX_CMD_GET_DATABASE_ENTRY;

	mbox_cmd[1] = (uint32_t) fw_ddb_index;

drivers/scsi/qla4xxx/ql4_os.c

+4 −0
Original line number Diff line number Diff line
@@ -4090,6 +4090,10 @@ static void qla4xxx_build_st_list(struct scsi_qla_host *ha, 
		if (ret == QLA_ERROR)

			break;



		/* Ignore DDB if invalid state (unassigned) */

		if (state == DDB_DS_UNASSIGNED)

			goto continue_next_st;



		/* Check if ST, add to the list_st */

		if (strlen((char *) fw_ddb_entry->iscsi_name) != 0)

			goto continue_next_st;