Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 96c25c81 authored by Vegard Nossum's avatar Vegard Nossum
Browse files

ieee1394/csr1212: fix false positive kmemcheck report 



kmemcheck reports a use of uninitialized memory here, but it's not
a real error. The structure in question has just been allocated, and
the whole field is initialized, but it happens in two steps.

We fix the false positive by inserting a kmemcheck annotation.

Signed-off-by: default avatarVegard Nossum <vegard.nossum@gmail.com>
parent 004cdb5a

drivers/ieee1394/csr1212.c

+2 −0
Original line number Diff line number Diff line
@@ -35,6 +35,7 @@ 


#include <linux/errno.h>

#include <linux/kernel.h>

#include <linux/kmemcheck.h>

#include <linux/string.h>

#include <asm/bug.h>

#include <asm/byteorder.h>
@@ -387,6 +388,7 @@ csr1212_new_descriptor_leaf(u8 dtype, u32 specifier_id, 
	if (!kv)

		return NULL;



	kmemcheck_annotate_variable(kv->value.leaf.data[0]);

	CSR1212_DESCRIPTOR_LEAF_SET_TYPE(kv, dtype);

	CSR1212_DESCRIPTOR_LEAF_SET_SPECIFIER_ID(kv, specifier_id);