Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 967e5620 authored by Bo Shen's avatar Bo Shen Committed by Greg Kroah-Hartman
Browse files

usb: gadget: udc: atmel: fix possible IN hang issue 



commit 6785a1034461c2d2c205215f63a50a740896e55b upstream.

When receive data, the RXRDY in status register set by hardware
after a new packet has been stored in the endpoint FIFO. When it
is copied from FIFO, this bit is cleared which make the FIFO can
be accessed again.

In the receive_data() function, this bit RXRDY has been cleared.
So, after the receive_data() function return, this bit should
not be cleared again, or else it may cause the accessing FIFO
corrupt, which will make the data loss.

Fixes: 914a3f3b (USB: add atmel_usba_udc driver)
Acked-by: default avatarNicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: default avatarBo Shen <voice.shen@atmel.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c8111884

drivers/usb/gadget/udc/atmel_usba_udc.c

+0 −1
Original line number Original line Diff line number Diff line
@@ -1572,7 +1572,6 @@ static void usba_ep_irq(struct usba_udc *udc, struct usba_ep *ep) 
	if ((epstatus & epctrl) & USBA_RX_BK_RDY) {

	if ((epstatus & epctrl) & USBA_RX_BK_RDY) {

		DBG(DBG_BUS, "%s: RX data ready\n", ep->ep.name);

		DBG(DBG_BUS, "%s: RX data ready\n", ep->ep.name);

		receive_data(ep);

		receive_data(ep);

		usba_ep_writel(ep, CLR_STA, USBA_RX_BK_RDY);

	}

	}

}

}