Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 963f803f authored by Takashi Iwai's avatar Takashi Iwai Committed by Jaroslav Kysela
Browse files

ALSA: hda - Don't reset SPDIF in each status change 



The SPDIF output is toggled at each time any SPDIF status bits are changed
because of the known problems on some codecs.  But, this also results in
loosing the sync, and the problem is more obvious on HDMI output over
SPDIF.  Since the toggle is necessary only for some codecs, we should
check whether this workaround is needed and skip if unnecessary.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarJaroslav Kysela <perex@perex.cz>
parent 6e8d90cd

sound/pci/hda/hda_codec.c

+2 −2
Original line number Diff line number Diff line
@@ -2590,12 +2590,12 @@ static void setup_dig_out_stream(struct hda_codec *codec, hda_nid_t nid, 
				 unsigned int stream_tag, unsigned int format)

{

	/* turn off SPDIF once; otherwise the IEC958 bits won't be updated */

	if (codec->spdif_ctls & AC_DIG1_ENABLE)

	if (codec->spdif_status_reset && (codec->spdif_ctls & AC_DIG1_ENABLE))

		snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_DIGI_CONVERT_1,

				    codec->spdif_ctls & ~AC_DIG1_ENABLE & 0xff);

	snd_hda_codec_setup_stream(codec, nid, stream_tag, 0, format);

	/* turn on again (if needed) */

	if (codec->spdif_ctls & AC_DIG1_ENABLE)

	if (codec->spdif_status_reset && (codec->spdif_ctls & AC_DIG1_ENABLE))

		snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_DIGI_CONVERT_1,

				    codec->spdif_ctls & 0xff);

}

sound/pci/hda/hda_codec.h

+5 −0
Original line number Diff line number Diff line
@@ -654,6 +654,11 @@ struct hda_codec { 


	struct snd_hwdep *hwdep;	/* assigned hwdep device */



	/* misc flags */

	unsigned int spdif_status_reset :1; /* needs to toggle SPDIF for each

					     * status change

					     * (e.g. Realtek codecs)

					     */

#ifdef CONFIG_SND_HDA_POWER_SAVE

	unsigned int power_on :1;	/* current (global) power-state */

	unsigned int power_transition :1; /* power-state in transition */

sound/pci/hda/patch_realtek.c

+2 −0
Original line number Diff line number Diff line
@@ -2670,6 +2670,8 @@ static int alc_build_pcms(struct hda_codec *codec) 
			info->stream[SNDRV_PCM_STREAM_CAPTURE] = *(spec->stream_digital_capture);

			info->stream[SNDRV_PCM_STREAM_CAPTURE].nid = spec->dig_in_nid;

		}

		/* FIXME: do we need this for all Realtek codec models? */

		codec->spdif_status_reset = 1;

	}



	/* If the use of more than one ADC is requested for the current