Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 963ba5fd authored by Namhyung Kim's avatar Namhyung Kim Committed by Arnaldo Carvalho de Melo
Browse files

perf sort: Fix a memory leak on srcline 



In the hist_entry__srcline_snprintf(), path and self->srcline are
pointing the same memory region, but they are doubly allocated.

Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
Reviewed-by: default avatarJiri Olsa <jolsa@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1378876173-13363-2-git-send-email-namhyung@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent fc67297b

tools/perf/util/sort.c

+1 −4
Original line number Diff line number Diff line
@@ -269,10 +269,7 @@ static int hist_entry__srcline_snprintf(struct hist_entry *self, char *bf, 
	if (!fp)

		goto out_ip;



	if (getline(&path, &line_len, fp) < 0 || !line_len)

		goto out_ip;

	self->srcline = strdup(path);

	if (self->srcline == NULL)

	if (getline(&self->srcline, &line_len, fp) < 0 || !line_len)

		goto out_ip;



	nl = strchr(self->srcline, '\n');