Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 95f71266 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Jiri Kosina
Browse files

HID: hid-wiimote: print small buffers via %*phC 



Instead of passing each byte through stack let's use %*phC specifier to dump
buffer as a hex string.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: default avatarDavid Herrmann <dh.herrmann@gmail.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 8e22ecb6

drivers/hid/hid-wiimote-core.c

+6 −11
Original line number Diff line number Diff line
@@ -441,8 +441,7 @@ static __u8 wiimote_cmd_read_ext(struct wiimote_data *wdata, __u8 *rmem) 
	if (ret != 6)

		return WIIMOTE_EXT_NONE;



	hid_dbg(wdata->hdev, "extension ID: %02x:%02x %02x:%02x %02x:%02x\n",

		rmem[0], rmem[1], rmem[2], rmem[3], rmem[4], rmem[5]);

	hid_dbg(wdata->hdev, "extension ID: %6phC\n", rmem);



	if (rmem[0] == 0xff && rmem[1] == 0xff && rmem[2] == 0xff &&

	    rmem[3] == 0xff && rmem[4] == 0xff && rmem[5] == 0xff)
@@ -520,14 +519,12 @@ static bool wiimote_cmd_read_mp(struct wiimote_data *wdata, __u8 *rmem) 
	if (ret != 6)

		return false;



	hid_dbg(wdata->hdev, "motion plus ID: %02x:%02x %02x:%02x %02x:%02x\n",

		rmem[0], rmem[1], rmem[2], rmem[3], rmem[4], rmem[5]);

	hid_dbg(wdata->hdev, "motion plus ID: %6phC\n", rmem);



	if (rmem[5] == 0x05)

		return true;



	hid_info(wdata->hdev, "unknown motion plus ID: %02x:%02x %02x:%02x %02x:%02x\n",

		 rmem[0], rmem[1], rmem[2], rmem[3], rmem[4], rmem[5]);

	hid_info(wdata->hdev, "unknown motion plus ID: %6phC\n", rmem);



	return false;

}
@@ -543,8 +540,7 @@ static __u8 wiimote_cmd_read_mp_mapped(struct wiimote_data *wdata) 
	if (ret != 6)

		return WIIMOTE_MP_NONE;



	hid_dbg(wdata->hdev, "mapped motion plus ID: %02x:%02x %02x:%02x %02x:%02x\n",

		rmem[0], rmem[1], rmem[2], rmem[3], rmem[4], rmem[5]);

	hid_dbg(wdata->hdev, "mapped motion plus ID: %6phC\n", rmem);



	if (rmem[0] == 0xff && rmem[1] == 0xff && rmem[2] == 0xff &&

	    rmem[3] == 0xff && rmem[4] == 0xff && rmem[5] == 0xff)
@@ -1138,9 +1134,8 @@ static void wiimote_init_hotplug(struct wiimote_data *wdata) 
		wiimote_ext_unload(wdata);



		if (exttype == WIIMOTE_EXT_UNKNOWN) {

			hid_info(wdata->hdev, "cannot detect extension; %02x:%02x %02x:%02x %02x:%02x\n",

				 extdata[0], extdata[1], extdata[2],

				 extdata[3], extdata[4], extdata[5]);

			hid_info(wdata->hdev, "cannot detect extension; %6phC\n",

				 extdata);

		} else if (exttype == WIIMOTE_EXT_NONE) {

			spin_lock_irq(&wdata->state.lock);

			wdata->state.exttype = WIIMOTE_EXT_NONE;