Commit 95ebcea6 authored Oct 22, 2012 by Joachim Eastwood Committed by David S. Miller Oct 23, 2012

net/macb: fix truncate warnings

When building macb on x86_64 the following warnings show up:
drivers/net/ethernet/cadence/macb.c: In function macb_interrupt:
drivers/net/ethernet/cadence/macb.c:556:4: warning: large integer implicitly truncated to unsigned type [-Woverflow]
drivers/net/ethernet/cadence/macb.c: In function macb_reset_hw:
drivers/net/ethernet/cadence/macb.c:792:2: warning: large integer implicitly truncated to unsigned type [-Woverflow]
drivers/net/ethernet/cadence/macb.c:793:2: warning: large integer implicitly truncated to unsigned type [-Woverflow]
drivers/net/ethernet/cadence/macb.c:796:2: warning: large integer implicitly truncated to unsigned type [-Woverflow]

Use -1 insted of ~0UL, as done in other places in the driver,
to silence these warnings.

Signed-off-by: Joachim Eastwood <manabian@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 51ebd318

drivers/net/ethernet/cadence/macb.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -553,7 +553,7 @@ static irqreturn_t macb_interrupt(int irq, void *dev_id)
		while (status) {
		/* close possible race with dev_close */
		if (unlikely(!netif_running(dev))) {
		macb_writel(bp, IDR, ~0UL);
		macb_writel(bp, IDR, -1);
		break;
		}

		@@ -789,11 +789,11 @@ static void macb_reset_hw(struct macb *bp)
		macb_writel(bp, NCR, MACB_BIT(CLRSTAT));

		/* Clear all status flags */
		macb_writel(bp, TSR, ~0UL);
		macb_writel(bp, RSR, ~0UL);
		macb_writel(bp, TSR, -1);
		macb_writel(bp, RSR, -1);

		/* Disable all interrupts */
		macb_writel(bp, IDR, ~0UL);
		macb_writel(bp, IDR, -1);
		macb_readl(bp, ISR);
		}