Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 95c9382a authored by Pavel Emelyanov's avatar Pavel Emelyanov Committed by David S. Miller
Browse files

[INET]: Use BUILD_BUG_ON in inet_timewait_sock.c checks 



Make the INET_TWDR_TWKILL_SLOTS vs sizeof(twdr->thread_slots)
check nicer.

Signed-off-by: default avatarPavel Emelyanov <xemul@openvz.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1f9e636e

net/ipv4/inet_timewait_sock.c

+2 −4
Original line number Diff line number Diff line
@@ -194,16 +194,14 @@ out: 


EXPORT_SYMBOL_GPL(inet_twdr_hangman);



extern void twkill_slots_invalid(void);



void inet_twdr_twkill_work(struct work_struct *work)

{

	struct inet_timewait_death_row *twdr =

		container_of(work, struct inet_timewait_death_row, twkill_work);

	int i;



	if ((INET_TWDR_TWKILL_SLOTS - 1) > (sizeof(twdr->thread_slots) * 8))

		twkill_slots_invalid();

	BUILD_BUG_ON((INET_TWDR_TWKILL_SLOTS - 1) >

			(sizeof(twdr->thread_slots) * 8));



	while (twdr->thread_slots) {

		spin_lock_bh(&twdr->death_lock);