Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 94bc9a7b authored by Dmitry Adamushko's avatar Dmitry Adamushko Committed by Ingo Molnar
Browse files

sched: remove activate_idle_task() 



cpu_down() code is ok wrt sched_idle_next() placing the 'idle' task not
at the beginning of the queue.

So get rid of activate_idle_task() and make use of activate_task() instead.
It is the same as activate_task(), except for the update_rq_clock(rq) call
that is redundant.

Code size goes down:

   text    data     bss     dec     hex filename
  47853    3934     336   52123    cb9b sched.o.before
  47828    3934     336   52098    cb82 sched.o.after

Signed-off-by: default avatarDmitry Adamushko <dmitry.adamushko@gmail.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent ce96b5ac

kernel/sched.c

+4 −18
Original line number Diff line number Diff line
@@ -5281,24 +5281,10 @@ static void migrate_live_tasks(int src_cpu) 
	read_unlock(&tasklist_lock);

}



/*

 * activate_idle_task - move idle task to the _front_ of runqueue.

 */

static void activate_idle_task(struct task_struct *p, struct rq *rq)

{

	update_rq_clock(rq);



	if (p->state == TASK_UNINTERRUPTIBLE)

		rq->nr_uninterruptible--;



	enqueue_task(rq, p, 0);

	inc_nr_running(p, rq);

}



/*

 * Schedules idle task to be the next runnable task on current CPU.

 * It does so by boosting its priority to highest possible and adding it to

 * the _front_ of the runqueue. Used by CPU offline code.

 * It does so by boosting its priority to highest possible.

 * Used by CPU offline code.

 */

void sched_idle_next(void)

{
@@ -5318,8 +5304,8 @@ void sched_idle_next(void) 


	__setscheduler(rq, p, SCHED_FIFO, MAX_RT_PRIO-1);



	/* Add idle task to the _front_ of its priority queue: */

	activate_idle_task(p, rq);

	update_rq_clock(rq);

	activate_task(rq, p, 0);



	spin_unlock_irqrestore(&rq->lock, flags);

}