Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 94a71110 authored by Wei Yongjun's avatar Wei Yongjun Committed by Nicholas Bellinger
Browse files

iser-target: fix error return code in isert_create_device_ib_res() 



Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Cc: <stable@vger.kernel.org> #3.10+
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 4454b66c

drivers/infiniband/ulp/isert/ib_isert.c

+12 −4
Original line number Diff line number Diff line
@@ -264,21 +264,29 @@ isert_create_device_ib_res(struct isert_device *device) 
						isert_cq_event_callback,

						(void *)&cq_desc[i],

						ISER_MAX_RX_CQ_LEN, i);

		if (IS_ERR(device->dev_rx_cq[i]))

		if (IS_ERR(device->dev_rx_cq[i])) {

			ret = PTR_ERR(device->dev_rx_cq[i]);

			device->dev_rx_cq[i] = NULL;

			goto out_cq;

		}



		device->dev_tx_cq[i] = ib_create_cq(device->ib_device,

						isert_cq_tx_callback,

						isert_cq_event_callback,

						(void *)&cq_desc[i],

						ISER_MAX_TX_CQ_LEN, i);

		if (IS_ERR(device->dev_tx_cq[i]))

		if (IS_ERR(device->dev_tx_cq[i])) {

			ret = PTR_ERR(device->dev_tx_cq[i]);

			device->dev_tx_cq[i] = NULL;

			goto out_cq;

		}



		if (ib_req_notify_cq(device->dev_rx_cq[i], IB_CQ_NEXT_COMP))

		ret = ib_req_notify_cq(device->dev_rx_cq[i], IB_CQ_NEXT_COMP);

		if (ret)

			goto out_cq;



		if (ib_req_notify_cq(device->dev_tx_cq[i], IB_CQ_NEXT_COMP))

		ret = ib_req_notify_cq(device->dev_tx_cq[i], IB_CQ_NEXT_COMP);

		if (ret)

			goto out_cq;

	}