Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9465d532 authored by Jeff Garzik's avatar Jeff Garzik
Browse files

ata/sata_fsl: Remove unnecessary SCR cases 



SCRs in the driver map to the standard values found in include/linux/ata.h,
so no need for individual scr_read/scr_write case statements duplicating
the natural value.

Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
Signed-off-by: default avatarLi Yang <leoli@freescale.com>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent a2962dd0

drivers/ata/sata_fsl.c

+2 −14
Original line number Original line Diff line number Diff line
@@ -472,16 +472,10 @@ static int sata_fsl_scr_write(struct ata_port *ap, unsigned int sc_reg_in, 




	switch (sc_reg_in) {

	switch (sc_reg_in) {

	case SCR_STATUS:

	case SCR_STATUS:

		sc_reg = 0;

		break;

	case SCR_ERROR:

	case SCR_ERROR:

		sc_reg = 1;

		break;

	case SCR_CONTROL:

	case SCR_CONTROL:

		sc_reg = 2;

		break;

	case SCR_ACTIVE:

	case SCR_ACTIVE:

		sc_reg = 3;

		sc_reg = sc_reg_in;

		break;

		break;

	default:

	default:

		return -EINVAL;

		return -EINVAL;
@@ -502,16 +496,10 @@ static int sata_fsl_scr_read(struct ata_port *ap, unsigned int sc_reg_in, 




	switch (sc_reg_in) {

	switch (sc_reg_in) {

	case SCR_STATUS:

	case SCR_STATUS:

		sc_reg = 0;

		break;

	case SCR_ERROR:

	case SCR_ERROR:

		sc_reg = 1;

		break;

	case SCR_CONTROL:

	case SCR_CONTROL:

		sc_reg = 2;

		break;

	case SCR_ACTIVE:

	case SCR_ACTIVE:

		sc_reg = 3;

		sc_reg = sc_reg_in;

		break;

		break;

	default:

	default:

		return -EINVAL;

		return -EINVAL;