Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9447057e authored by Libo Chen's avatar Libo Chen Committed by Greg Kroah-Hartman
Browse files

platform_device: use a macro instead of platform_driver_register 



I found a lot of mistakes using struct platform_driver without owner
so I make a macro instead of the function platform_driver_register.
It can set owner in it, then guys don`t care about module owner again.

Signed-off-by: default avatarLibo Chen <libo.chen@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f494513f

drivers/base/platform.c

+5 −3
Original line number Diff line number Diff line
@@ -523,11 +523,13 @@ static void platform_drv_shutdown(struct device *_dev) 
}



/**

 * platform_driver_register - register a driver for platform-level devices

 * __platform_driver_register - register a driver for platform-level devices

 * @drv: platform driver structure

 */

int platform_driver_register(struct platform_driver *drv)

int __platform_driver_register(struct platform_driver *drv,

				struct module *owner)

{

	drv->driver.owner = owner;

	drv->driver.bus = &platform_bus_type;

	if (drv->probe)

		drv->driver.probe = platform_drv_probe;
@@ -538,7 +540,7 @@ int platform_driver_register(struct platform_driver *drv) 


	return driver_register(&drv->driver);

}

EXPORT_SYMBOL_GPL(platform_driver_register);

EXPORT_SYMBOL_GPL(__platform_driver_register);



/**

 * platform_driver_unregister - unregister a driver for platform-level devices

include/linux/platform_device.h

+7 −1
Original line number Diff line number Diff line
@@ -180,7 +180,13 @@ struct platform_driver { 
	const struct platform_device_id *id_table;

};



extern int platform_driver_register(struct platform_driver *);

/*

 * use a macro to avoid include chaining to get THIS_MODULE

 */

#define platform_driver_register(drv) \

	__platform_driver_register(drv, THIS_MODULE)

extern int __platform_driver_register(struct platform_driver *,

					struct module *);

extern void platform_driver_unregister(struct platform_driver *);



/* non-hotpluggable platform devices may use this so that probe() and