Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 92d0d66c authored by Julia Lawall's avatar Julia Lawall Committed by Mauro Carvalho Chehab
Browse files

[media] drivers/media/dvb/ttpci/av7110_av.c: Add missing error handling code 

Extend the error handling code with operations found in other nearby error
handling code.

A simplified version of the sematic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@r exists@
@r@
statement S1,S2,S3;
constant C1,C2,C3;
@@

*if (...)
 {... S1 return -C1;}
...
*if (...)
 {... when != S1
    return -C2;}
...
*if (...)
 {... S1 return -C3;}
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent bdd1751b

drivers/media/dvb/ttpci/av7110_av.c

+4 −1
Original line number Diff line number Diff line
@@ -245,8 +245,11 @@ int av7110_pes_play(void *dest, struct dvb_ringbuffer *buf, int dlen) 
		return -1;

	}

	while (1) {

		if ((len = dvb_ringbuffer_avail(buf)) < 6)

		len = dvb_ringbuffer_avail(buf);

		if (len < 6) {

			wake_up(&buf->queue);

			return -1;

		}

		sync =  DVB_RINGBUFFER_PEEK(buf, 0) << 24;

		sync |= DVB_RINGBUFFER_PEEK(buf, 1) << 16;

		sync |= DVB_RINGBUFFER_PEEK(buf, 2) << 8;