Commit 92b0ca7c authored Jul 25, 2013 by Dan Carpenter Committed by Roland Dreier Jul 31, 2013

IB/mlx5: Fix stack info leak in mlx5_ib_alloc_ucontext()



We don't set "resp.reserved".  Since it's at the end of the struct
that means we don't have to copy it to the user.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Eli Cohen <eli@mellanox.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>

parent 281d1a92

drivers/infiniband/hw/mlx5/main.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -619,7 +619,8 @@ static struct ib_ucontext mlx5_ib_alloc_ucontext(struct ib_device ibdev,

		resp.tot_uuars = req.total_num_uuars;
		resp.num_ports = dev->mdev.caps.num_ports;
		err = ib_copy_to_udata(udata, &resp, sizeof(resp));
		err = ib_copy_to_udata(udata, &resp,
		sizeof(resp) - sizeof(resp.reserved));
		if (err)
		goto out_uars;