Commit 923f18a8 authored Sep 14, 2017 by Stefan Popa Committed by Greg Kroah-Hartman Oct 12, 2017

staging: iio: ad7192: Fix - use the dedicated reset function avoiding dma from stack.

commit f790923f146140a261ad211e5baf75d169f16fb2 upstream.

Depends on: 691c4b95d1 ("iio: ad_sigma_delta: Implement a dedicated reset function")

SPI host drivers can use DMA to transfer data, so the buffer should be properly allocated.
Keeping it on the stack could cause an undefined behavior.

The dedicated reset function solves this issue.

Signed-off-by: Stefan Popa <stefan.popa@analog.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 440edb76

drivers/staging/iio/adc/ad7192.c

+1 −3

Original line number	Original line	Diff line number	Diff line
	@@ -206,11 +206,9 @@ static int ad7192_setup(struct ad7192_state *st,
	struct iio_dev *indio_dev = spi_get_drvdata(st->sd.spi);		struct iio_dev *indio_dev = spi_get_drvdata(st->sd.spi);
	unsigned long long scale_uv;		unsigned long long scale_uv;
	int i, ret, id;		int i, ret, id;
	u8 ones[6];

	/* reset the serial interface */		/* reset the serial interface */
	memset(&ones, 0xFF, 6);		ret = ad_sd_reset(&st->sd, 48);
	ret = spi_write(st->sd.spi, &ones, 6);
	if (ret < 0)		if (ret < 0)
	goto out;		goto out;
	usleep_range(500, 1000); /* Wait for at least 500us */		usleep_range(500, 1000); /* Wait for at least 500us */