Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 90beca5d authored by Tejun Heo's avatar Tejun Heo
Browse files

workqueue: move WORKER_REBIND clearing in rebind_workers() to the end of the function 



This doesn't make any functional difference and is purely to help the
next patch to be simpler.

Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>
parent 96e65306

kernel/workqueue.c

+13 −13
Original line number Diff line number Diff line
@@ -1422,19 +1422,7 @@ retry: 
		goto retry;

	}



	/*

	 * All idle workers are rebound and waiting for %WORKER_REBIND to

	 * be cleared inside idle_worker_rebind().  Clear and release.

	 * Clearing %WORKER_REBIND from this foreign context is safe

	 * because these workers are still guaranteed to be idle.

	 */

	for_each_worker_pool(pool, gcwq)

		list_for_each_entry(worker, &pool->idle_list, entry)

			worker->flags &= ~WORKER_REBIND;



	wake_up_all(&gcwq->rebind_hold);



	/* rebind busy workers */

	/* all idle workers are rebound, rebind busy workers */

	for_each_busy_worker(worker, i, pos, gcwq) {

		struct work_struct *rebind_work = &worker->rebind_work;

		unsigned long worker_flags = worker->flags;
@@ -1454,6 +1442,18 @@ retry: 
			    worker->scheduled.next,

			    work_color_to_flags(WORK_NO_COLOR));

	}



	/*

	 * All idle workers are rebound and waiting for %WORKER_REBIND to

	 * be cleared inside idle_worker_rebind().  Clear and release.

	 * Clearing %WORKER_REBIND from this foreign context is safe

	 * because these workers are still guaranteed to be idle.

	 */

	for_each_worker_pool(pool, gcwq)

		list_for_each_entry(worker, &pool->idle_list, entry)

			worker->flags &= ~WORKER_REBIND;



	wake_up_all(&gcwq->rebind_hold);

}



static struct worker *alloc_worker(void)