Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 90a6fb12 authored by Chen Gang's avatar Chen Gang Committed by Ralf Baechle
Browse files

MIPS: Lantiq: Use strlcpy() instead of strncpy(). 



'compatible' is used by strlen() in __of_device_is_compatible().

Ensure strings are always '\0' terminated.

'of_ids is not a structure in "include/uapi/*", so no need to initialize
it completly; using strlcpy() instead of strncpy() will do.

Signed-off-by: default avatarChen Gang <gang.chen@asianux.com>
Acked-by: default avatarJohn Crispin <blogic@openwrt.org>
Cc: linux-mips@linux-mips.org
Cc: Linux-Arch <linux-arch@vger.kernel.org>
Patchwork: https://patchwork.linux-mips.org/patch/5329/


Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent 0ec31512

arch/mips/lantiq/prom.c

+1 −1
Original line number Diff line number Diff line
@@ -112,7 +112,7 @@ int __init plat_of_setup(void) 
	if (!of_have_populated_dt())

		panic("device tree not present");



	strncpy(of_ids[0].compatible, soc_info.compatible,

	strlcpy(of_ids[0].compatible, soc_info.compatible,

		sizeof(of_ids[0].compatible));

	strncpy(of_ids[1].compatible, "simple-bus",

		sizeof(of_ids[1].compatible));