Commit 9091224f authored Jul 17, 2007 by J. Bruce Fields Committed by Linus Torvalds Jul 17, 2007

knfsd: nfsd: allow auth_sys nlm on rpcsec_gss exports



Our clients (like other clients, as far as I know) use only auth_sys for nlm,
even when using rpcsec_gss for the main nfs operations.

Administrators that want to deny non-kerberos-authenticated locking requests
will need to turn off NFS protocol versions less than 4....

Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu>
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 4796f457

fs/nfsd/nfsfh.c

+10 −4

Original line number	Diff line number	Diff line
		@@ -249,10 +249,16 @@ fh_verify(struct svc_rqst rqstp, struct svc_fh fhp, int type, int access)
		if (error)
		goto out;

		/* Check security flavor */
		if (!(access & MAY_LOCK)) {
		/*
		* pseudoflavor restrictions are not enforced on NLM,
		* which clients virtually always use auth_sys for,
		* even while using RPCSEC_GSS for NFS.
		*/
		error = check_nfsd_access(exp, rqstp);
		if (error)
		goto out;
		}

		/* Finally, check access permissions. */
		error = nfsd_permission(rqstp, exp, dentry, access);