Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 906c3b61 authored by Nicolas Kaiser's avatar Nicolas Kaiser Committed by Colin Cross
Browse files

arm: tegra: fix error check in tegra2_clocks.c 



Checking 'rate < 0' doesn't work because 'rate' is unsigned.

Signed-off-by: default avatarNicolas Kaiser <nikai@nikai.net>
Signed-off-by: default avatarColin Cross <ccross@android.com>
parent c8309ef6

arch/arm/mach-tegra/tegra2_clocks.c

+5 −4
Original line number Diff line number Diff line
@@ -1362,14 +1362,15 @@ static int tegra_clk_shared_bus_set_rate(struct clk *c, unsigned long rate) 
{

	unsigned long flags;

	int ret;

	long new_rate = rate;



	rate = clk_round_rate(c->parent, rate);

	if (rate < 0)

		return rate;

	new_rate = clk_round_rate(c->parent, new_rate);

	if (new_rate < 0)

		return new_rate;



	spin_lock_irqsave(&c->parent->spinlock, flags);



	c->u.shared_bus_user.rate = rate;

	c->u.shared_bus_user.rate = new_rate;

	ret = tegra_clk_shared_bus_update(c->parent);



	spin_unlock_irqrestore(&c->parent->spinlock, flags);