Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 900853a4 authored by Julia Lawall's avatar Julia Lawall Committed by David S. Miller
Browse files

drivers/net/qlcnic: Use available error codes 

The error code is stored in the variable err, but it is the variable ret
that is returned instead.  So store the error code in ret.  Err is then
useless.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@r@
local idexpression x;
constant C;
@@

if (...) { ...
  x = -C
  ... when != x
(
  return <+...x...+>;
|
  return NULL;
|
  return;
|
* return ...;
)
}
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 49339cca

drivers/net/qlcnic/qlcnic_main.c

+3 −3
Original line number Diff line number Diff line
@@ -474,7 +474,7 @@ static int 
qlcnic_init_pci_info(struct qlcnic_adapter *adapter)

{

	struct qlcnic_pci_info *pci_info;

	int i, ret = 0, err;

	int i, ret = 0;

	u8 pfn;



	pci_info = kcalloc(QLCNIC_MAX_PCI_FUNC, sizeof(*pci_info), GFP_KERNEL);
@@ -484,14 +484,14 @@ qlcnic_init_pci_info(struct qlcnic_adapter *adapter) 
	adapter->npars = kzalloc(sizeof(struct qlcnic_npar_info) *

				QLCNIC_MAX_PCI_FUNC, GFP_KERNEL);

	if (!adapter->npars) {

		err = -ENOMEM;

		ret = -ENOMEM;

		goto err_pci_info;

	}



	adapter->eswitch = kzalloc(sizeof(struct qlcnic_eswitch) *

				QLCNIC_NIU_MAX_XG_PORTS, GFP_KERNEL);

	if (!adapter->eswitch) {

		err = -ENOMEM;

		ret = -ENOMEM;

		goto err_npars;

	}