Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8fc96351 authored by Jon Cooper's avatar Jon Cooper Committed by David S. Miller
Browse files

sfc: remove incorrect EFX_BUG_ON_PARANOID check 



write_count and insert_count can wrap around, making > check invalid.

Fixes: 70b33fb0 ("sfc: add support for
 skb->xmit_more").

Signed-off-by: default avatarEdward Cree <ecree@solarflare.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7c1c97d5

drivers/net/ethernet/sfc/tx.c

+0 −4
Original line number Diff line number Diff line
@@ -343,8 +343,6 @@ netdev_tx_t efx_enqueue_skb(struct efx_tx_queue *tx_queue, struct sk_buff *skb) 
	unsigned short dma_flags;

	int i = 0;



	EFX_BUG_ON_PARANOID(tx_queue->write_count > tx_queue->insert_count);



	if (skb_shinfo(skb)->gso_size)

		return efx_enqueue_skb_tso(tx_queue, skb);
@@ -1258,8 +1256,6 @@ static int efx_enqueue_skb_tso(struct efx_tx_queue *tx_queue, 
	/* Find the packet protocol and sanity-check it */

	state.protocol = efx_tso_check_protocol(skb);



	EFX_BUG_ON_PARANOID(tx_queue->write_count > tx_queue->insert_count);



	rc = tso_start(&state, efx, skb);

	if (rc)

		goto mem_err;