Commit 8fc61d92 authored Apr 12, 2014 by Lukas Czerner Committed by Theodore Ts'o Apr 12, 2014

fs: prevent doing FALLOC_FL_ZERO_RANGE on append only file



Currently punch hole and collapse range fallocate operation are not
allowed on append only file. This should be case for zero range as well.
Fix it by allowing only pure fallocate (possibly with keep size set).

Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>

parent 9ef06cec

fs/open.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -254,11 +254,9 @@ int do_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
		return -EBADF;

		/*
		* It's not possible to punch hole or perform collapse range
		* on append only file
		* We can only allow pure fallocate on append only files
		*/
		if (mode & (FALLOC_FL_PUNCH_HOLE \| FALLOC_FL_COLLAPSE_RANGE)
		&& IS_APPEND(inode))
		if ((mode & ~FALLOC_FL_KEEP_SIZE) && IS_APPEND(inode))
		return -EPERM;

		if (IS_IMMUTABLE(inode))