Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8f22757e authored by Dave Jones's avatar Dave Jones Committed by David S. Miller
Browse files

[TUN]: Fix leak in tun_get_user() 



We're leaking an skb in a failure path in this function.

Coverity #632
Signed-off-by: default avatarDave Jones <davej@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 53574487

drivers/net/tun.c

+4 −1
Original line number Diff line number Diff line
@@ -249,8 +249,11 @@ static __inline__ ssize_t tun_get_user(struct tun_struct *tun, struct iovec *iv, 


	if (align)

		skb_reserve(skb, align);

	if (memcpy_fromiovec(skb_put(skb, len), iv, len))

	if (memcpy_fromiovec(skb_put(skb, len), iv, len)) {

		tun->stats.rx_dropped++;

		kfree_skb(skb);

		return -EFAULT;

	}



	skb->dev = tun->dev;

	switch (tun->flags & TUN_TYPE_MASK) {