Commit 8f1c14b2 authored Jun 23, 2010 by Eric Dumazet Committed by David S. Miller Jun 23, 2010

snmp: fix SNMP_ADD_STATS()



commit aa2ea058 (tcp: fix outsegs stat for TSO segments) incorrectly
assumed SNMP_ADD_STATS() was used from BH context.

Fix this using mib[!in_softirq()] instead of mib[0]

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: Tom Herbert <therbert@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 8ceedea7

include/net/snmp.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -134,7 +134,7 @@ struct linux_xfrm_mib {
		#define SNMP_ADD_STATS_USER(mib, field, addend) \
		this_cpu_add(mib[1]->mibs[field], addend)
		#define SNMP_ADD_STATS(mib, field, addend) \
		this_cpu_add(mib[0]->mibs[field], addend)
		this_cpu_add(mib[!in_softirq()]->mibs[field], addend)
		/*
		* Use "__typeof__(mib[0]) ptr" instead of "__typeof__(mib[0]) ptr"
		* to make @ptr a non-percpu pointer.