Commit 8e1a03b6 authored Sep 10, 2014 by Or Gerlitz Committed by David S. Miller Sep 10, 2014

mlx4: Fix wrong endianess access with QP context flags



We wrongly tested QP context bits without BE conversion
as was spotted by sparse...

drivers/infiniband/hw/mlx4/qp.c:1685:38: sparse: restricted __be32 degrades to integer

Fix that!

Fixes: d2fce8a9 ('mlx4: Set user-space raw Ethernet QPs to properly handle VXLAN traffic')
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7319a1a4

drivers/infiniband/hw/mlx4/qp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1682,7 +1682,7 @@ static int __mlx4_ib_modify_qp(struct ib_qp *ibqp,
		MLX4_IB_LINK_TYPE_ETH;
		if (dev->dev->caps.tunnel_offload_mode == MLX4_TUNNEL_OFFLOAD_MODE_VXLAN) {
		/* set QP to receive both tunneled & non-tunneled packets */
		if (!(context->flags & (1 << MLX4_RSS_QPC_FLAG_OFFSET)))
		if (!(context->flags & cpu_to_be32(1 << MLX4_RSS_QPC_FLAG_OFFSET)))
		context->srqn = cpu_to_be32(7 << 28);
		}
		}