Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d73e0e7 authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

checkpatch: quiet Kconfig help message checking 



Editing Kconfig dependencies can emit unnecessary messages about missing
or too short help entries.

Only emit the message when adding help sections to Kconfig files.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Reported-by: default avatarJean Delvare <jdelvare@suse.de>
Tested-by: default avatarJean Delvare <jdelvare@suse.de>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent fee0aa83

scripts/checkpatch.pl

+4 −3
Original line number Diff line number Diff line
@@ -2052,7 +2052,7 @@ sub process { 
# Only applies when adding the entry originally, after that we do not have

# sufficient context to determine whether it is indeed long enough.

		if ($realfile =~ /Kconfig/ &&

		    $line =~ /.\s*config\s+/) {

		    $line =~ /^\+\s*config\s+/) {

			my $length = 0;

			my $cnt = $realcnt;

			my $ln = $linenr + 1;
@@ -2065,10 +2065,11 @@ sub process { 
				$is_end = $lines[$ln - 1] =~ /^\+/;



				next if ($f =~ /^-/);

				last if (!$file && $f =~ /^\@\@/);



				if ($lines[$ln - 1] =~ /.\s*(?:bool|tristate)\s*\"/) {

				if ($lines[$ln - 1] =~ /^\+\s*(?:bool|tristate)\s*\"/) {

					$is_start = 1;

				} elsif ($lines[$ln - 1] =~ /.\s*(?:---)?help(?:---)?$/) {

				} elsif ($lines[$ln - 1] =~ /^\+\s*(?:---)?help(?:---)?$/) {

					$length = -1;

				}