Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8cf6de71 authored by Andy Whitcroft's avatar Andy Whitcroft Committed by Linus Torvalds
Browse files

checkpatch: add check for space after struct, union, and enum 



Add spacing checks for struct, union, and enum definitions.  Check the
spacing after type and before the equals (=) and open brace ({).

Based on a patch by Joe Perches.

Cc: Joe Perches <joe@perches.com>
Signed-off-by: default avatarAndy Whitcroft <apw@canonical.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 53a3c448

scripts/checkpatch.pl

+10 −0
Original line number Diff line number Diff line
@@ -1905,6 +1905,16 @@ sub process { 
			ERROR("open brace '{' following function declarations go on the next line\n" . $herecurr);

		}



# missing space after union or struct definition

		if ($rawline =~ /^\+\s*(union|struct)\s+$Ident[=\{]/) {

		    WARN("Missing space after struct or union definition\n" . $herecurr);

		}



# missing space after enum definition

		if ($rawline =~ /^\+\s*enum\{/) {

		    WARN("Missing space after enum definition\n" . $herecurr);

		}



# open braces for enum, union and struct go on the same line.

		if ($line =~ /^.\s*{/ &&

		    $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) {