Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8cd578b6 authored by Mark Brown's avatar Mark Brown Committed by Linus Walleij
Browse files

gpiolib: wm8994: Pay attention to the value set when enabling as output 



Not paying attention to the value being set is a bad thing because it
means that we'll not set the hardware up to reflect what was requested.
Not setting the hardware up to reflect what was requested means that the
caller won't get the results they wanted.

Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent afcc0f8c

drivers/gpio/gpio-wm8994.c

+4 −1
Original line number Diff line number Diff line
@@ -89,8 +89,11 @@ static int wm8994_gpio_direction_out(struct gpio_chip *chip, 
	struct wm8994_gpio *wm8994_gpio = to_wm8994_gpio(chip);

	struct wm8994 *wm8994 = wm8994_gpio->wm8994;



	if (value)

		value = WM8994_GPN_LVL;



	return wm8994_set_bits(wm8994, WM8994_GPIO_1 + offset,

			       WM8994_GPN_DIR, 0);

			       WM8994_GPN_DIR | WM8994_GPN_LVL, value);

}



static void wm8994_gpio_set(struct gpio_chip *chip, unsigned offset, int value)