Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8ca5d2d8 authored by Chanho Min's avatar Chanho Min Committed by Mauro Carvalho Chehab
Browse files

[media] uvcvideo: Fix data type for pan/tilt control 



The pan/tilt absolute control value is signed value. If minimum value
is minus, It will be changed to plus by clamp_t() as commit 64ae9958.
([media] uvcvideo: Fix control value clamping for unsigned integer controls).
It leads to wrong setting of the control values. For example,
when min and max are -36000 and 36000, the setting value between of this range
is always 36000. So, its data type should be changed to signed.

Signed-off-by: default avatarChanho Min <chanho.min@lge.com>
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
parent 60b3b4d2

drivers/media/usb/uvc/uvc_ctrl.c

+2 −2
Original line number Diff line number Diff line
@@ -664,7 +664,7 @@ static struct uvc_control_mapping uvc_ctrl_mappings[] = { 
		.size		= 32,

		.offset		= 0,

		.v4l2_type	= V4L2_CTRL_TYPE_INTEGER,

		.data_type	= UVC_CTRL_DATA_TYPE_UNSIGNED,

		.data_type	= UVC_CTRL_DATA_TYPE_SIGNED,

	},

	{

		.id		= V4L2_CID_TILT_ABSOLUTE,
@@ -674,7 +674,7 @@ static struct uvc_control_mapping uvc_ctrl_mappings[] = { 
		.size		= 32,

		.offset		= 32,

		.v4l2_type	= V4L2_CTRL_TYPE_INTEGER,

		.data_type	= UVC_CTRL_DATA_TYPE_UNSIGNED,

		.data_type	= UVC_CTRL_DATA_TYPE_SIGNED,

	},

	{

		.id		= V4L2_CID_PRIVACY,