Commit 8bfe15f3 authored Apr 17, 2010 by Mike Lockwood Committed by Greg Kroah-Hartman Nov 30, 2011

Staging: android: timed_gpio: Properly discard invalid timeout values.



The timed output device never previously checked the return value of sscanf,
resulting in an uninitialized int being passed to enable() if input value
was invalid.

Signed-off-by: Mike Lockwood <lockwood@android.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 16b66554

drivers/staging/android/timed_output.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -41,7 +41,9 @@ static ssize_t enable_store(
		struct timed_output_dev *tdev = dev_get_drvdata(dev);
		int value;

		sscanf(buf, "%d", &value);
		if (sscanf(buf, "%d", &value) != 1)
		return -EINVAL;

		tdev->enable(tdev, value);

		return size;