Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8bcfbd0a authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

isdn: gigaset: use after free 



I moved the kfree(cb) below the dereferences.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7e27a0ae

drivers/isdn/gigaset/bas-gigaset.c

+4 −2
Original line number Diff line number Diff line
@@ -1914,11 +1914,13 @@ static int gigaset_write_cmd(struct cardstate *cs, struct cmdbuf_t *cb) 
	 * The next command will reopen the AT channel automatically.

	 */

	if (cb->len == 3 && !memcmp(cb->buf, "+++", 3)) {

		kfree(cb);

		rc = req_submit(cs->bcs, HD_CLOSE_ATCHANNEL, 0, BAS_TIMEOUT);

		if (cb->wake_tasklet)

			tasklet_schedule(cb->wake_tasklet);

		return rc < 0 ? rc : cb->len;

		if (!rc)

			rc = cb->len;

		kfree(cb);

		return rc;

	}



	spin_lock_irqsave(&cs->cmdlock, flags);