Commit 8a5daf1e authored Mar 11, 2014 by Simon Derr Committed by Eric Van Hensbergen Mar 25, 2014

9pnet_rdma: check token type before int conversion



When parsing options, make sure we have found a proper token before
doing a numeric conversion.

Without this check, the current code will end up following random
pointers that just happened to be on the stack when this function was
called, because match_token() will not touch the 'args' list unless a
valid token is found.

Signed-off-by: Simon Derr <simon.derr@bull.net>
Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>

parent 263c5828

net/9p/trans_rdma.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -193,6 +193,8 @@ static int parse_opts(char params, struct p9_rdma_opts opts)
		if (!*p)
		continue;
		token = match_token(p, tokens, args);
		if (token == Opt_err)
		continue;
		r = match_int(&args[0], &option);
		if (r < 0) {
		p9_debug(P9_DEBUG_ERROR,