Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8a472da4 authored by Wey-Yi Guy's avatar Wey-Yi Guy Committed by John W. Linville
Browse files

iwlwifi: separated time check for different type of force reset 



Use different timing duration check for different type of force reset,
force reset request can come from different source and based on
different reason; one type of reset request should not block other type of
reset request.

Adding structure to keep track of different force reset request.

Signed-off-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent d5755939

drivers/net/wireless/iwlwifi/iwl-agn.c

+6 −0
Original line number Diff line number Diff line
@@ -3378,6 +3378,12 @@ static int iwl_init_drv(struct iwl_priv *priv) 
	priv->missed_beacon_threshold = IWL_MISSED_BEACON_THRESHOLD_DEF;

	priv->agg_tids_count = 0;



	/* initialize force reset */

	priv->force_reset[IWL_RF_RESET].reset_duration =

		IWL_DELAY_NEXT_FORCE_RF_RESET;

	priv->force_reset[IWL_FW_RESET].reset_duration =

		IWL_DELAY_NEXT_FORCE_FW_RELOAD;



	/* Choose which receivers/antennas to use */

	if (priv->cfg->ops->hcmd->set_rxon_chain)

		priv->cfg->ops->hcmd->set_rxon_chain(priv);

drivers/net/wireless/iwlwifi/iwl-core.c

+14 −11
Original line number Diff line number Diff line
@@ -3357,22 +3357,30 @@ static void iwl_force_rf_reset(struct iwl_priv *priv) 
	return;

}



#define IWL_DELAY_NEXT_FORCE_RESET (HZ*3)



int iwl_force_reset(struct iwl_priv *priv, int mode)

{

	struct iwl_force_reset *force_reset;



	if (test_bit(STATUS_EXIT_PENDING, &priv->status))

		return -EINVAL;



	if (priv->last_force_reset_jiffies &&

	    time_after(priv->last_force_reset_jiffies +

		       IWL_DELAY_NEXT_FORCE_RESET, jiffies)) {

	if (mode >= IWL_MAX_FORCE_RESET) {

		IWL_DEBUG_INFO(priv, "invalid reset request.\n");

		return -EINVAL;

	}

	force_reset = &priv->force_reset[mode];

	force_reset->reset_request_count++;

	if (force_reset->last_force_reset_jiffies &&

	    time_after(force_reset->last_force_reset_jiffies +

	    force_reset->reset_duration, jiffies)) {

		IWL_DEBUG_INFO(priv, "force reset rejected\n");

		force_reset->reset_reject_count++;

		return -EAGAIN;

	}



	force_reset->reset_success_count++;

	force_reset->last_force_reset_jiffies = jiffies;

	IWL_DEBUG_INFO(priv, "perform force reset (%d)\n", mode);



	switch (mode) {

	case IWL_RF_RESET:

		iwl_force_rf_reset(priv);
@@ -3389,12 +3397,7 @@ int iwl_force_reset(struct iwl_priv *priv, int mode) 
		clear_bit(STATUS_READY, &priv->status);

		queue_work(priv->workqueue, &priv->restart);

		break;

	default:

		IWL_DEBUG_INFO(priv, "invalid reset request.\n");

		return -EINVAL;

	}

	priv->last_force_reset_jiffies = jiffies;



	return 0;

}

drivers/net/wireless/iwlwifi/iwl-dev.h

+13 −1
Original line number Diff line number Diff line
@@ -1036,9 +1036,21 @@ struct iwl_event_log { 
#define IWL_MAX_PLCP_ERR_EXT_LONG_THRESHOLD_DEF	(200)

#define IWL_MAX_PLCP_ERR_THRESHOLD_MAX	(255)



#define IWL_DELAY_NEXT_FORCE_RF_RESET  (HZ*3)

#define IWL_DELAY_NEXT_FORCE_FW_RELOAD (HZ*5)



enum iwl_reset {

	IWL_RF_RESET = 0,

	IWL_FW_RESET,

	IWL_MAX_FORCE_RESET,

};



struct iwl_force_reset {

	int reset_request_count;

	int reset_success_count;

	int reset_reject_count;

	unsigned long reset_duration;

	unsigned long last_force_reset_jiffies;

};



struct iwl_priv {
@@ -1076,7 +1088,7 @@ struct iwl_priv { 
	u8 agg_tids_count;



	/* force reset */

	unsigned long last_force_reset_jiffies;

	struct iwl_force_reset force_reset[IWL_MAX_FORCE_RESET];



	/* we allocate array of iwl4965_channel_info for NIC's valid channels.

	 *    Access via channel # using indirect index array */