Commit 89f4d45b authored Oct 25, 2013 by Wei Yongjun Committed by Mauro Carvalho Chehab Nov 29, 2013

[media] saa7164: fix return value check in saa7164_initdev()



In case of error, the function kthread_run() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Cc: stable@vger.kernel.org
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

parent f8e1b699

drivers/media/pci/saa7164/saa7164-core.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1354,10 +1354,12 @@ static int saa7164_initdev(struct pci_dev *pci_dev,
		if (fw_debug) {
		dev->kthread = kthread_run(saa7164_thread_function, dev,
		"saa7164 debug");
		if (!dev->kthread)
		if (IS_ERR(dev->kthread)) {
		dev->kthread = NULL;
		printk(KERN_ERR "%s() Failed to create "
		"debug kernel thread\n", __func__);
		}
		}

		} /* != BOARD_UNKNOWN */
		else