Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 899be96d authored by Axel Lin's avatar Axel Lin Committed by Paul Mundt
Browse files

rtc: rtc-sh - fix a memory leak 



request_mem_region() will call kzalloc to allocate memory for struct resource.
release_resource() unregisters the resource but does not free the allocated
memory, thus use release_mem_region() instead to fix the memory leak.

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Signed-off-by: default avatarPaul Mundt <lethal@linux-sh.org>
parent 151f52f0

drivers/rtc/rtc-sh.c

+2 −2
Original line number Diff line number Diff line
@@ -761,7 +761,7 @@ err_unmap: 
	clk_put(rtc->clk);

	iounmap(rtc->regbase);

err_badmap:

	release_resource(rtc->res);

	release_mem_region(rtc->res->start, rtc->regsize);

err_badres:

	kfree(rtc);
@@ -786,7 +786,7 @@ static int __exit sh_rtc_remove(struct platform_device *pdev) 
	}



	iounmap(rtc->regbase);

	release_resource(rtc->res);

	release_mem_region(rtc->res->start, rtc->regsize);



	clk_disable(rtc->clk);

	clk_put(rtc->clk);