Commit 8948ed2f authored Aug 11, 2017 by Jiang Yi Committed by Greg Kroah-Hartman Dec 20, 2017

target/file: Do not return error for UNMAP if length is zero




[ Upstream commit 594e25e73440863981032d76c9b1e33409ceff6e ]

The function fd_execute_unmap() in target_core_file.c calles

ret = file->f_op->fallocate(file, mode, pos, len);

Some filesystems implement fallocate() to return error if
length is zero (e.g. btrfs) but according to SCSI Block
Commands spec UNMAP should return success for zero length.

Signed-off-by: Jiang Yi <jiangyilism@gmail.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent e6da104c

drivers/target/target_core_file.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -592,6 +592,10 @@ fd_do_unmap(struct se_cmd cmd, void priv, sector_t lba, sector_t nolb)
		struct inode *inode = file->f_mapping->host;
		int ret;

		if (!nolb) {
		return 0;
		}

		if (cmd->se_dev->dev_attrib.pi_prot_type) {
		ret = fd_do_prot_unmap(cmd, lba, nolb);
		if (ret)