Commit 88e7df0b authored Nov 03, 2008 by Ed Swierk Committed by Jesse Barnes Nov 03, 2008

PCI: fix range check on mmapped sysfs resource files

pci_mmap_fits() returns the wrong answer if the sysfs resource file size
is not a multiple of the page size. vm_end and vm_start are already
page-aligned, so size - start < nr, causing mmap() to return EINVAL.

Signed-off-by: Ed Swierk <eswierk@aristanetworks.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

parent f5dafca5

drivers/pci/pci-sysfs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -575,7 +575,7 @@ static int pci_mmap_fits(struct pci_dev *pdev, int resno, struct vm_area_struct

		nr = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
		start = vma->vm_pgoff;
		size = pci_resource_len(pdev, resno) >> PAGE_SHIFT;
		size = ((pci_resource_len(pdev, resno) - 1) >> PAGE_SHIFT) + 1;
		if (start < size && size - start >= nr)
		return 1;
		WARN(1, "process \"%s\" tried to map 0x%08lx-0x%08lx on %s BAR %d (size 0x%08lx)\n",