Commit 889635fd authored Aug 03, 2010 by Kulikov Vasiliy Committed by David S. Miller Aug 04, 2010

via-velocity: do not use PCI resources before pci_enable_device()



IRQ and resource[] may not have correct values until
after PCI hotplug setup occurs at pci_enable_device() time.

The semantic match that finds this problem is as follows:

// <smpl>
@@
identifier x;
identifier request ~= "pci_request.*|pci_resource.*";
@@

(
* x->irq
|
* x->resource
|
* request(x, ...)
)
 ...
*pci_enable_device(x)
// </smpl>

Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7a0c2029

drivers/net/via-velocity.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -2763,12 +2763,12 @@ static int __devinit velocity_found1(struct pci_dev *pdev, const struct pci_devi

		vptr->dev = dev;

		dev->irq = pdev->irq;

		ret = pci_enable_device(pdev);
		if (ret < 0)
		goto err_free_dev;

		dev->irq = pdev->irq;

		ret = velocity_get_pci_info(vptr, pdev);
		if (ret < 0) {
		/* error message already printed */