Commit 8800a244 authored Mar 24, 2014 by Monam Agarwal Committed by David S. Miller Mar 27, 2014

drivers/net: Use RCU_INIT_POINTER(x, NULL) in bonding/bond_options.c

This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

The rcu_assign_pointer() ensures that the initialization of a structure
is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there is no structure to initialize.
So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 203191c3

drivers/net/bonding/bond_options.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -712,7 +712,7 @@ static int bond_option_active_slave_set(struct bonding *bond,
		/* check to see if we are clearing active */
		if (!slave_dev) {
		pr_info("%s: Clearing current active slave\n", bond->dev->name);
		rcu_assign_pointer(bond->curr_active_slave, NULL);
		RCU_INIT_POINTER(bond->curr_active_slave, NULL);
		bond_select_active_slave(bond);
		} else {
		struct slave *old_active = bond->curr_active_slave;