Commit 87a46909 authored Jun 28, 2014 by Guillaume Morin Committed by Jonathan Cameron Jun 29, 2014

staging: iio: ad9850.c: code cleanup



checkpath.pl was complaining about value_mask:
ERROR: Macros with complex values should be enclosed in parenthesis

I fixed this by simply removing it since it's not used (as well as another
macro).  Got rid of the un-necessary error_ret label as well.

Signed-off-by: Guillaume Morin <guillaume@morinfr.org>
Reported-by: Michael Welling <mwelling@ieee.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

parent fc167f62

drivers/staging/iio/frequency/ad9850.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -21,9 +21,6 @@

		#define DRV_NAME "ad9850"

		#define value_mask (u16)0xf000
		#define addr_shift 12

		/* Register format: 4 bits addr + 12 bits value */
		struct ad9850_config {
		u8 control[5];
		@@ -50,9 +47,6 @@ static ssize_t ad9850_set_parameter(struct device *dev,
		mutex_lock(&st->lock);

		ret = spi_sync_transfer(st->sdev, &xfer, 1);
		if (ret)
		goto error_ret;
		error_ret:
		mutex_unlock(&st->lock);

		return ret ? ret : len;