Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 87a17389 authored by Frej Drejhammar's avatar Frej Drejhammar Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (7452): cx88: Enable chroma AGC by default for all non-SECAM modes 



An enabled chroma AGC will not degrade picture quality if enabled on a
color PAL or NTSC signal with nominal signal levels. It will give a
significant color reproduction improvement if the chroma signals
diverge from nominal levels. Therefore enable chroma AGC by default
for PAL and NTSC standards.

Signed-off-by: default avatar"Frej Drejhammar <frej.drejhammar@gmail.com&gt;">
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
parent 6d04203c

drivers/media/video/cx88/cx88-core.c

+4 −5
Original line number Diff line number Diff line
@@ -929,11 +929,10 @@ int cx88_set_tvnorm(struct cx88_core *core, v4l2_std_id norm) 


	dprintk(1,"set_tvnorm: MO_INPUT_FORMAT  0x%08x [old=0x%08x]\n",

		cxiformat, cx_read(MO_INPUT_FORMAT) & 0x0f);

	/* Chroma AGC must be disabled if SECAM is used */

	if (norm & V4L2_STD_SECAM)

		cx_andor(MO_INPUT_FORMAT, 0x40f, cxiformat);

	else

		cx_andor(MO_INPUT_FORMAT, 0xf, cxiformat);

	/* Chroma AGC must be disabled if SECAM is used, we enable it

	   by default on PAL and NTSC */

	cx_andor(MO_INPUT_FORMAT, 0x40f,

		 norm & V4L2_STD_SECAM ? cxiformat : cxiformat | 0x400);



	// FIXME: as-is from DScaler

	dprintk(1,"set_tvnorm: MO_OUTPUT_FORMAT 0x%08x [old=0x%08x]\n",

drivers/media/video/cx88/cx88-video.c

+1 −1
Original line number Diff line number Diff line
@@ -233,7 +233,7 @@ static struct cx88_ctrl cx8800_ctls[] = { 
			.name          = "Chroma AGC",

			.minimum       = 0,

			.maximum       = 1,

			.default_value = 0x0,

			.default_value = 0x1,

			.type          = V4L2_CTRL_TYPE_BOOLEAN,

		},

		.reg                   = MO_INPUT_FORMAT,