Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 86ef4dbf authored by Tejun Heo's avatar Tejun Heo
Browse files

x86, NUMA: Drop @start/last_pfn from initmem_init() 



initmem_init() extensively accesses and modifies global data
structures and the parameters aren't even followed depending on which
path is being used.  Drop @start/last_pfn and let it deal with
@max_pfn directly.  This is in preparation for further NUMA init
cleanups.

- v2: x86-32 initmem_init() weren't updated breaking 32bit builds.
  Fixed.  Found by Yinghai.

Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Shaohui Zheng <shaohui.zheng@intel.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: H. Peter Anvin <hpa@linux.intel.com>
parent 13081df5

arch/x86/include/asm/page_types.h

+1 −2
Original line number Diff line number Diff line
@@ -56,8 +56,7 @@ extern unsigned long init_memory_mapping(unsigned long start, 


void init_memory_mapping_high(void);



extern void initmem_init(unsigned long start_pfn, unsigned long end_pfn,

				int acpi, int k8);

extern void initmem_init(int acpi, int k8);

extern void free_initmem(void);



#endif	/* !__ASSEMBLY__ */

arch/x86/kernel/setup.c

+1 −1
Original line number Diff line number Diff line
@@ -1003,7 +1003,7 @@ void __init setup_arch(char **cmdline_p) 
		amd = !amd_numa_init(0, max_pfn);

#endif



	initmem_init(0, max_pfn, acpi, amd);

	initmem_init(acpi, amd);

	memblock_find_dma_reserve();

	dma32_reserve_bootmem();

arch/x86/mm/init_32.c

+1 −2
Original line number Diff line number Diff line
@@ -644,8 +644,7 @@ void __init find_low_pfn_range(void) 
}



#ifndef CONFIG_NEED_MULTIPLE_NODES

void __init initmem_init(unsigned long start_pfn, unsigned long end_pfn,

				int acpi, int k8)

void __init initmem_init(int acpi, int k8)

{

#ifdef CONFIG_HIGHMEM

	highstart_pfn = highend_pfn = max_pfn;

arch/x86/mm/init_64.c

+2 −3
Original line number Diff line number Diff line
@@ -603,10 +603,9 @@ kernel_physical_mapping_init(unsigned long start, 
}



#ifndef CONFIG_NUMA

void __init initmem_init(unsigned long start_pfn, unsigned long end_pfn,

				int acpi, int k8)

void __init initmem_init(int acpi, int k8)

{

	memblock_x86_register_active_regions(0, start_pfn, end_pfn);

	memblock_x86_register_active_regions(0, 0, max_pfn);

	init_memory_mapping_high();

}

#endif

arch/x86/mm/numa_32.c

+1 −2
Original line number Diff line number Diff line
@@ -352,8 +352,7 @@ static void init_remap_allocator(int nid) 
		(ulong) node_remap_end_vaddr[nid]);

}



void __init initmem_init(unsigned long start_pfn, unsigned long end_pfn,

				int acpi, int k8)

void __init initmem_init(int acpi, int k8)

{

	int nid;

	long kva_target_pfn;