Commit 86669530 authored Jul 19, 2009 by Julia Lawall Committed by David S. Miller Jul 21, 2009

drivers/net/mlx4: Adjust constant

The values in the advertising field are typically ADVERTISED_xxx, not
SUPPORTED_xxx.  Both SUPPORTED_10000baseT_Full and
ADVERTISED_1000baseT_Full have the same value.

The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/

)

// <smpl>
@@
struct ethtool_cmd E;
@@
*E.advertising = SUPPORTED_10000baseT_Full
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 0376d5b2

drivers/net/mlx4/en_ethtool.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -220,7 +220,7 @@ static int mlx4_en_get_settings(struct net_device dev, struct ethtool_cmd cmd)
		{
		cmd->autoneg = AUTONEG_DISABLE;
		cmd->supported = SUPPORTED_10000baseT_Full;
		cmd->advertising = SUPPORTED_10000baseT_Full;
		cmd->advertising = ADVERTISED_1000baseT_Full;
		if (netif_carrier_ok(dev)) {
		cmd->speed = SPEED_10000;
		cmd->duplex = DUPLEX_FULL;