Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 861934c7 authored by Patrick McHardy's avatar Patrick McHardy Committed by David S. Miller
Browse files

[NETFILTER]: nfnetlink_queue: eliminate impossible switch case 



We don't need a default case in nfqnl_build_packet_message(), the
copy_mode is validated when it is set. Tell the compiler about
the possible types and remove the default case. Saves 80b of
text on x86_64.

Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ea3a66ff

net/netfilter/nfnetlink_queue.c

+1 −6
Original line number Diff line number Diff line
@@ -232,7 +232,7 @@ nfqnl_build_packet_message(struct nfqnl_instance *queue, 


	spin_lock_bh(&queue->lock);



	switch (queue->copy_mode) {

	switch ((enum nfqnl_config_mode)queue->copy_mode) {

	case NFQNL_COPY_META:

	case NFQNL_COPY_NONE:

		data_len = 0;
@@ -253,11 +253,6 @@ nfqnl_build_packet_message(struct nfqnl_instance *queue, 


		size += nla_total_size(data_len);

		break;



	default:

		*errp = -EINVAL;

		spin_unlock_bh(&queue->lock);

		return NULL;

	}



	entry->id = queue->id_sequence++;