Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 85c5798b authored by Stefan Richter's avatar Stefan Richter
Browse files

ieee1394: ohci1394: don't schedule IT tasklets on IR events 

Bug noted by Pieter Palmers:  Isochronous transmit tasklets were
scheduled on isochronous receive events, in addition to the proper
isochronous receive tasklets.

http://marc.info/?l=linux1394-devel&m=119783196222802



Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
parent 4e6343a1

drivers/ieee1394/ohci1394.c

+8 −4
Original line number Diff line number Diff line
@@ -2126,11 +2126,15 @@ static void ohci_schedule_iso_tasklets(struct ti_ohci *ohci, 
	list_for_each_entry(t, &ohci->iso_tasklet_list, link) {

		mask = 1 << t->context;



		if (t->type == OHCI_ISO_TRANSMIT && tx_event & mask)

		if (t->type == OHCI_ISO_TRANSMIT) {

			if (tx_event & mask)

				tasklet_schedule(&t->tasklet);

		else if (rx_event & mask)

		} else {

			/* OHCI_ISO_RECEIVE or OHCI_ISO_MULTICHANNEL_RECEIVE */

			if (rx_event & mask)

				tasklet_schedule(&t->tasklet);

		}

	}



	spin_unlock_irqrestore(&ohci->iso_tasklet_list_lock, flags);

}