Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 85b8582d authored by Vincent Palatin's avatar Vincent Palatin Committed by Jesse Barnes
Browse files

PCI/PM/Runtime: make PCI traces quieter 



When the runtime PM is activated on PCI, if a device switches state
frequently (e.g. an EHCI controller with autosuspending USB devices
connected) the PCI configuration traces might be very verbose in the
kernel log.  Let's guard those traces with DEBUG condition.

Acked-by: default avatar"Rafael J. Wysocki" <rjw@sisk.pl>
Signed-off-by: default avatarVincent Palatin <vpalatin@chromium.org>
Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
parent 118faafa

drivers/acpi/pci_irq.c

+5 −5
Original line number Diff line number Diff line
@@ -487,7 +487,7 @@ int acpi_pci_irq_enable(struct pci_dev *dev) 
	else

		link_desc[0] = '\0';



	dev_info(&dev->dev, "PCI INT %c%s -> GSI %u (%s, %s) -> IRQ %d\n",

	dev_dbg(&dev->dev, "PCI INT %c%s -> GSI %u (%s, %s) -> IRQ %d\n",

		pin_name(pin), link_desc, gsi,

		(triggering == ACPI_LEVEL_SENSITIVE) ? "level" : "edge",

		(polarity == ACPI_ACTIVE_LOW) ? "low" : "high", dev->irq);
@@ -524,6 +524,6 @@ void acpi_pci_irq_disable(struct pci_dev *dev) 
	 * (e.g. PCI_UNDEFINED_IRQ).

	 */



	dev_info(&dev->dev, "PCI INT %c disabled\n", pin_name(pin));

	dev_dbg(&dev->dev, "PCI INT %c disabled\n", pin_name(pin));

	acpi_unregister_gsi(gsi);

}

drivers/pci/pci.c

+2 −3
Original line number Diff line number Diff line
@@ -973,7 +973,7 @@ void pci_restore_state(struct pci_dev *dev) 
	for (i = 15; i >= 0; i--) {

		pci_read_config_dword(dev, i * 4, &val);

		if (val != dev->saved_config_space[i]) {

			dev_printk(KERN_DEBUG, &dev->dev, "restoring config "

			dev_dbg(&dev->dev, "restoring config "

				"space at offset %#x (was %#x, writing %#x)\n",

				i, val, (int)dev->saved_config_space[i]);

			pci_write_config_dword(dev,i * 4,
@@ -1542,8 +1542,7 @@ void pci_pme_active(struct pci_dev *dev, bool enable) 
	}



out:

	dev_printk(KERN_DEBUG, &dev->dev, "PME# %s\n",

			enable ? "enabled" : "disabled");

	dev_dbg(&dev->dev, "PME# %s\n", enable ? "enabled" : "disabled");

}



/**

drivers/pci/setup-res.c

+3 −3
Original line number Diff line number Diff line
@@ -85,7 +85,7 @@ void pci_update_resource(struct pci_dev *dev, int resno) 
		}

	}

	res->flags &= ~IORESOURCE_UNSET;

	dev_info(&dev->dev, "BAR %d: set to %pR (PCI address [%#llx-%#llx])\n",

	dev_dbg(&dev->dev, "BAR %d: set to %pR (PCI address [%#llx-%#llx])\n",

		resno, res, (unsigned long long)region.start,

		(unsigned long long)region.end);

}