Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 859b9ef3 authored by Andrew Paprocki's avatar Andrew Paprocki Committed by Jean Delvare
Browse files

hwmon: (it87) Fix fan tachometer reading in IT8712F rev 0x7 (I) 



The IT8712F v0.9.1 datasheet applies to revisions >= 0x8 (J).
The driver was incorrectly attempting to enable 16-bit fan
readings on rev 0x7 (I) which led to incorrect RPM values.

Signed-off-by: default avatarAndrew Paprocki <andrew@ishiboo.com>
Tested-by: default avatarJohn Gumb <john.gumb@tandberg.com>
Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
parent 13b3c3fa

drivers/hwmon/it87.c

+2 −2
Original line number Diff line number Diff line
@@ -273,10 +273,10 @@ struct it87_data { 
static inline int has_16bit_fans(const struct it87_data *data)

{

	/* IT8705F Datasheet 0.4.1, 3h == Version G.

	   IT8712F Datasheet 0.9.1, section 8.3.5 indicates 7h == Version I.

	   IT8712F Datasheet 0.9.1, section 8.3.5 indicates 8h == Version J.

	   These are the first revisions with 16bit tachometer support. */

	return (data->type == it87 && data->revision >= 0x03)

	    || (data->type == it8712 && data->revision >= 0x07)

	    || (data->type == it8712 && data->revision >= 0x08)

	    || data->type == it8716

	    || data->type == it8718;

}