Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8586ea96 authored by Julia Lawall's avatar Julia Lawall Committed by Jiri Kosina
Browse files

pktcdvd: fix error return code

Set the return variable to an error code as done elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}

// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 644ff181
Loading
Loading
Loading
Loading
+3 −1
Original line number Diff line number Diff line
@@ -706,7 +706,9 @@ static int pkt_generic_packet(struct pktcdvd_device *pd, struct packet_command *
			     WRITE : READ, __GFP_WAIT);

	if (cgc->buflen) {
		if (blk_rq_map_kern(q, rq, cgc->buffer, cgc->buflen, __GFP_WAIT))
		ret = blk_rq_map_kern(q, rq, cgc->buffer, cgc->buflen,
				      __GFP_WAIT);
		if (ret)
			goto out;
	}